Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py and MANIFEST.in to include environment files and add … #38

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

atstarke
Copy link
Collaborator

Provides fix for issue #14
-Fixed pip install issues. Updates to setup.py and MANIFEST.in
-Now, pip installing should ensure that the environments are included in the library's installation.

Copy link
Member

@mwydmuch mwydmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pre-commit checks need to be fixed.

tests/test_magent2.py Outdated Show resolved Hide resolved
tests/test_magent2.py Outdated Show resolved Hide resolved
Copy link
Member

@mwydmuch mwydmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more comments regarding this PR, it is generally ok, but some stuff seems to be unnecessary addition.

tests/test_magent2.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@mwydmuch
Copy link
Member

I don't have the right to approve workflows for this repo; should I ask someone? Or will you do it @atstarke?

Copy link
Member

@mwydmuch mwydmuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@atstarke atstarke merged commit 34cafaa into Farama-Foundation:main Aug 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants