Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more helpful error messages if users use a mixture of Gym and Gymnasium #957

Conversation

pseudo-rnd-thoughts
Copy link
Member

Description

I have found several users using a mixture of Gym and gymnasium, I believe due to thinking that

import gymnasium as gym 
from gym.utils import play

will causes the second statement to use gymnasium not gym mistakenly.

This PR adds more helpful error checking for check_env, make and the passive environment checker that runs in the background on make.
Tests are included but will be turned off by default as the CI doesn't install gym so pytest.importorskip is used if users include gym locally

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit d684778 into Farama-Foundation:main Mar 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant