-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] MJX
environment prototype (WIP)
#834
base: main
Are you sure you want to change the base?
[RFC] MJX
environment prototype (WIP)
#834
Conversation
`tests/env/mujoco/test_mojoco_v3.py`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool WIP. Cannot wait to have this properly ported. May I ask what are the biggest blocking points?
gymnasium/envs/mujoco/f.py
Outdated
- exclude_current_positions_from_observation | ||
) | ||
|
||
self.observation_space = gymnasium.spaces.Box( # TODO use jnp when and if `Box` supports jax natively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess we'll need to make spaces compatible with jax to be able to sample in jit compiled training function
gymnasium/envs/mujoco/f.py
Outdated
self.camera_id = camera_id | ||
self.camera_name = camera_name | ||
|
||
return MujocoRenderer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that jax native too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it is not, and the render functions will not be JITable for a while (if ever), because of the structure of the deepming/mujoco
project
gymnasium/envs/mujoco/f.py
Outdated
) | ||
|
||
|
||
# TODO add vector environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be super simple. It's essentially vmap step and reset
Thanks for this work. I have a few question regarding the WIP. In particular is there any training script that support the MJX Envs. I am asking this, since the return structure of some of the functions, and no mention of truncated in the environments in the PR suggest that, currently something other way of using these environments. |
|
MJX
environment prototypeMJX
environment prototype (will be resumed after1.0)
MJX
environment prototype (will be resumed after1.0)MJX
environment prototype (WIP)
I have paused development, waiting for
mjx==3.2
& a few updates onFuncEnv
related proposal (read first): #833
Feel free to comment on anything you want, but in particular check the
NOTE
commentsChecklist
MJX
classInvertedDoublePendulum
,InvertedPendulum
)HalfCheetah
,Hopper
,Walker2D
)Reacher
,Pusher
)Swimmer
)Ant
)Humanoid
,HumanoidStandup
)