Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial notebook for Blackjack-v1 #64

Merged
merged 8 commits into from
Oct 23, 2022
Merged

Add a tutorial notebook for Blackjack-v1 #64

merged 8 commits into from
Oct 23, 2022

Conversation

till2
Copy link
Contributor

@till2 till2 commented Oct 18, 2022

This PR adds the Blackjack-v1 tutorial for gym version v26.

The notebook should be compatible with Sphinx according to the Sphinx-Notebook docs.

If any changes to the tutorial are needed please let me know.

@pseudo-rnd-thoughts
Copy link
Member

Currently, we only support python files not jupyter notebook though we plan to add this. You can possibly use this example https://gist.github.com/chsasank/7218ca16f8d022e02a9c0deb94a310fe

@till2
Copy link
Contributor Author

till2 commented Oct 19, 2022

Converted it to a python file. @pseudo-rnd-thoughts

@till2
Copy link
Contributor Author

till2 commented Oct 20, 2022

Resolved the formatting & it is below 100k episodes now (with still mostly decent results).
Can you test if the AE-loop picture at the top shows up (if the link works)? @mgoulao

Also removed LaTeX plot labels (to have less dependencies).

@pseudo-rnd-thoughts
Copy link
Member

@till2 For the future, could you resolve comments that you have solved along with a reaction or comment just so it is easier to know the progress of the PR.

@pseudo-rnd-thoughts
Copy link
Member

@till2 I think this is close to merging. Could you fix the pre-commit issues, https://github.com/Farama-Foundation/Gymnasium/blob/main/CONTRIBUTING.md

@till2
Copy link
Contributor Author

till2 commented Oct 22, 2022

@till2 I think this is close to merging. Could you fix the pre-commit issues, https://github.com/Farama-Foundation/Gymnasium/blob/main/CONTRIBUTING.md

Should work now, it's passing locally.

@till2 till2 closed this Oct 22, 2022
@till2 till2 reopened this Oct 22, 2022
@till2
Copy link
Contributor Author

till2 commented Oct 23, 2022

Great, ready to merge @pseudo-rnd-thoughts

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 67ab18e into Farama-Foundation:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants