-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gym-Gymnasium compatibility converter #61
Gym-Gymnasium compatibility converter #61
Conversation
…essage Disable the default tests for gym envs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of initial comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is all good, could you update the PR top comment from "WiP" to be more descriptive and provide a short description of the PR rational over the prior ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a __get_attr__
function to get attributes from the gym environment
I'd rather not do that, I'm already slightly uneasy with the way getattr is handled in wrappers. If users need to access something from the backend environment, they can just do |
Based on many external discussions, this implements a way to use gym environments inside gymnasium.
They can be created in two ways -- either pass it by name with optional arguments to create an env from the gym registry:
or use an arbitrary instantiated gym env
At the moment it only supports the modern API used in gym 0.26, in the future we might add support for the old API, though at that point it might enter a dependency hell. We'll see.