Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py cleanup #58

Merged
merged 16 commits into from
Oct 14, 2022
Merged

setup.py cleanup #58

merged 16 commits into from
Oct 14, 2022

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Oct 14, 2022 •
edited
Loading

Description

This updates the setup.py file to be consistent with that of PettingZoo.
The list of changes are as follows:

  • Move version into gymnasium/init.py
  • Updated license
  • Edit setup to be in line with that of pettingzoo

pseudo-rnd-thoughts
pseudo-rnd-thoughts reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the need to change the gymnasium setup.py or change version. The current method seemed simple and effective method of doing it. I don't understand the change

@jjshoots
Copy link
Member Author

Ready for review @pseudo-rnd-thoughts

pseudo-rnd-thoughts
pseudo-rnd-thoughts reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a comment on the version variable

setup.py Show resolved Hide resolved
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 274b17d into Farama-Foundation:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjshoots @pseudo-rnd-thoughts