Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check_environments_match function for checking if two environments are identical #576

Merged
merged 7 commits into from
Jul 1, 2023
Merged

add check_environments_match function for checking if two environments are identical #576

merged 7 commits into from
Jul 1, 2023

Conversation

Kallinteris-Andreas
Copy link
Collaborator

Description

implements #575

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as draft June 29, 2023 14:42
@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review June 29, 2023 16:08
pseudo-rnd-thoughts
pseudo-rnd-thoughts requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the mujoco version test to use this function?

gymnasium/utils/env_tests.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to env_match

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant the filename rather the function name, I think check_environments_match is a good name

@Kallinteris-Andreas
Copy link
Collaborator Author

test_mujoco_v3 does not check for equality it checks for close "enought", which this function does not support

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title add check_environments_match add check_environments_match function for checking if two environments are identical Jul 1, 2023
pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only worry is that we don't have any testing but I don't imagine this being a popular function

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit b6f07b6 into Farama-Foundation:main Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kallinteris-Andreas @pseudo-rnd-thoughts