-
-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow Box
low > high
and low == inf
and high == -inf
#495
Conversation
Box
with inf
lower bounds and -inf
upper bounds
Box
with inf
lower bounds and -inf
upper boundsBox
low > high and low == inf and high == -inf
As Therefore, I propose you just prevent three cases, |
@jjshoots Are you happy with the changes that I made? If so, I'm happy to merge |
Box
low > high and low == inf and high == -infBox
low > high
and low == inf
and high == -inf
@pseudo-rnd-thoughts Yep, SGTM. |
Description
This disallows the user from creating box spaces where the range is 0.
Fixes #493
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)