Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hint fixes and added __all__ dunder #321

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Type hint fixes and added __all__ dunder #321

merged 2 commits into from
Feb 12, 2023

Conversation

howardh
Copy link
Contributor

@howardh howardh commented Feb 12, 2023

  • Made some changes so that pyright doesn't think Env.step() is supposed to return None.
  • infos was mistyped as a list[dist] when it should be dict. Fixed the type hint and verified that the types are correct in the unit tests.
  • Exposed the colorize and EzPickle utils

pseudo-rnd-thoughts
pseudo-rnd-thoughts requested changes Feb 12, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks these look good, could you revert the **kwargs issue then will merge

gymnasium/vector/vector_env.py Outdated Show resolved Hide resolved
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 79ae76e into Farama-Foundation:main Feb 12, 2023
@howardh howardh deleted the howard2 branch February 12, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howardh @pseudo-rnd-thoughts