Update vector space utility functions for all spaces #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm slightly confused by this, as I understand this is just refactoring of existing code, except it's put into the experimental directory, so it kinda looks like new code in the diff? Wouldn't it be better to just change it in the live version of the repo, and then it will get merged with the experimental stuff when that becomes stable? |
# Conflicts: # gymnasium/vector/utils/numpy_utils.py
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
pseudo-rnd-thoughts
changed the title
# Conflicts: # gymnasium/experimental/vector/__init__.py
# Conflicts: # gymnasium/experimental/vector/utils/__init__.py # gymnasium/experimental/vector/utils/space_utils.py # tests/experimental/vector/__init__.py # tests/experimental/vector/utils/__init__.py # tests/experimental/vector/utils/test_space_utils.py
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # tests/spaces/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am improving some of the wrappers and I found that we can use several of the built-in vector functions for generating empty arrays, stacking observations, etc
In this PR, I have copied the original space utility functions from vector which were in two files,
spacesandnumpy_utilsinto a single file,space_utils, the functions arebatch_space,concatenate,iterateandcreate_empty_arrayI have not changed the implementation of the functions other than adding new functions for the
Sequence,Text,GraphspacesFor testing, I have not included expected outputs for each of the functions. This can be added, rather I have opted for functionality testing of the functions, in particular the interface between the four functions