Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(envs): fix docstring and update action space description #123

Merged
merged 6 commits into from
Nov 11, 2022
Merged

docs(envs): fix docstring and update action space description #123

merged 6 commits into from
Nov 11, 2022

Conversation

Thytu
Copy link
Contributor

@Thytu Thytu commented Nov 11, 2022 •
edited
Loading

  • fix min and max position values in montain_car's observation space
  • fix min and max velocity values in montain_car's observation space
  • fix montain_car's action space description
  • update lunar lander's action space description
  • update blackjack's action space description
  • update cartpole's action space description
  • update car racing's action space description

Description

Fix error in environment description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Thytu
docs(montain_car): fix docstring
f58504c 
* fix min and max position values in montain_car's observation space
* fix min and max velocity values in montain_car's observation space
* fix montain_car's action space description
Thytu added 4 commits November 11, 2022 20:43
@Thytu
docs(carpole): update action space description
821cefb
@Thytu
docs(rac_racing): update action space description
af7df4e 
change rac_racing's action space description to be a list
@Thytu
docs(lunar_lander): update action space description
a53c506 
update lunar_lander's action space description to be a list
@Thytu
docs(blackjack): update action space description
a7702a6 
update blackjack's action space description to be a list
@Thytu Thytu changed the title docs(montain_car): fix docstring docs(envs): fix docstring and update action space description Nov 11, 2022
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit f8ea4df into Farama-Foundation:main Nov 11, 2022
@pseudo-rnd-thoughts
Copy link
Member

Thanks for the PR, if you spot anymore issues on the website (https://gymnasium.farama.org/), please make PRs to fix them

@Thytu Thytu deleted the patch-1 branch November 11, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thytu @pseudo-rnd-thoughts