Merged
Conversation
Avoids the somewhat expensive stack.Caller invocation by checking if it is needed
wsodsong
approved these changes
Sep 8, 2023
Collaborator
wsodsong
left a comment
wsodsong
left a comment
There was a problem hiding this comment.
Thank you for bringing the fix to this repo.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pull of a fix made by ethereum developers:
ethereum/go-ethereum#28069
Opera currently consumes 2% of runtime in generating stacktraces in logging (especially in trace logs) even when the logging is disabled and when the logger does not use these stacktraces. This fixes that.