Skip to content

Add Carmen integration#1

Merged
thaarok merged 2 commits into
developfrom
jkalina/carmen-into-opera
May 19, 2023
Merged

Add Carmen integration#1
thaarok merged 2 commits into
developfrom
jkalina/carmen-into-opera

Conversation

@thaarok
Copy link
Copy Markdown
Collaborator

@thaarok thaarok commented May 12, 2023 •
edited
Loading

Seems working ok with fakenet 1/1.
Prepared to be tested in Norma.
Use --statedb.impl=go-file to run with Carmen.

Stopping needs to be handled yet, need to remove the datadir after each run for now.

@thaarok thaarok requested a review from andrecronje as a code owner May 12, 2023 17:46
@thaarok thaarok removed the request for review from andrecronje May 12, 2023 17:46
@thaarok thaarok force-pushed the jkalina/carmen-into-opera branch 2 times, most recently from b75d021 to b4f9b96 Compare May 16, 2023 14:45
@thaarok thaarok changed the title Add Carmen in elementary form Add Carmen integration May 16, 2023
@thaarok thaarok requested a review from HerbertJordan May 16, 2023 17:42
HerbertJordan
HerbertJordan requested changes May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

I have just a few minor requests and questions, please see the individual comments.

Comment thread carmenadapter/carmen.go Outdated
Comment thread gossip/blockproc/evmmodule/evm.go Outdated
Comment thread gossip/c_event_callbacks.go Outdated
Comment thread gossip/evmstore/store.go
Comment thread carmenadapter/switch.go Outdated
Comment thread carmenadapter/switch.go Outdated
@thaarok thaarok mentioned this pull request May 17, 2023
Merged
@thaarok thaarok force-pushed the jkalina/carmen-into-opera branch from b4f9b96 to 11bc1f8 Compare May 19, 2023 09:04
@thaarok thaarok force-pushed the jkalina/carmen-into-opera branch from 11bc1f8 to 997baa2 Compare May 19, 2023 09:18
@thaarok thaarok requested a review from HerbertJordan May 19, 2023 09:21
@thaarok
Copy link
Copy Markdown
Collaborator Author

thaarok commented May 19, 2023

Updated:

  • logs management in carmen
  • mutex-protected parallel access into the live state - used for block processing, for txpool and also for RPC with block=latest

HerbertJordan
HerbertJordan approved these changes May 19, 2023
View reviewed changes
Comment thread gossip/blockproc/evmmodule/evm.go Outdated
@thaarok thaarok merged commit 9d4226c into develop May 19, 2023
@thaarok thaarok deleted the jkalina/carmen-into-opera branch May 19, 2023 11:03
@thaarok thaarok mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HerbertJordan HerbertJordan HerbertJordan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaarok @HerbertJordan