Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Media Cube #743

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

navarchus
Copy link
Contributor

Fixes #390
Add hidden entry in book gated by advancement. Explains function of Media Cube once it has been put into Player's inventory.

@object-Object
Copy link
Member

something seems messed up with the commits - there are some commits on this branch that are also on main but with a different SHA.

@navarchus
Copy link
Contributor Author

navarchus commented Sep 5, 2024

something seems messed up with the commits - there are some commits on this branch that are also on main but with a different SHA.

I did a force push to revert an unnecessary commit, should I just open a new PR?

@object-Object
Copy link
Member

you can if you want, or you could fix it with rebase, or I can probably fix it if I get a chance

@navarchus
Copy link
Contributor Author

you can if you want, or you could fix it with rebase, or I can probably fix it if I get a chance

I'll give it a shot tomorrow

@gamma-delta
Copy link
Collaborator

I feel like if we're documenting the media cube we should probably document the stuff it does (does it still have the thing where it displays all the patterns executed based on the anvil rename?)

@object-Object
Copy link
Member

debug patterns still works, but debug media doesn't (#640)

@gamma-delta
Copy link
Collaborator

Again this is something I'd rather not block the release on. Hexdebug is a way better debugger anyways.

@gamma-delta
Copy link
Collaborator

For the non-tracing things, I think the tooltip explains what it does just fine.

@object-Object
Copy link
Member

mmm, yeah. the point of #390 was specifically to document those hidden features accessible by renaming the item.

@navarchus
Copy link
Contributor Author

I can take a second pass at this and redo the documentation sometime this week if that's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Planned
Development

Successfully merging this pull request may close these issues.

Hidden debug cube features should be documented somewhere
4 participants