Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #283 fix delete graph #291

Merged
merged 3 commits into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/graph/DeleteGraph.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default function DeleteGraph({ graphName, isOpen, onOpen, onDeleteGraph,
graphName: string
isOpen: boolean
onOpen: (open: boolean) => void
onDeleteGraph: () => void
onDeleteGraph: (option: string) => void
isSchema: boolean
}) {

Expand All @@ -19,7 +19,7 @@ export default function DeleteGraph({ graphName, isOpen, onOpen, onDeleteGraph,

if (result.ok) {
Toast(`${type} ${graphName} deleted`, "Success")
onDeleteGraph()
onDeleteGraph(graphName)
}
}

Expand Down
21 changes: 11 additions & 10 deletions app/components/ui/combobox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ interface ComboboxProps {
setSelectedValue: (value: string) => void,
isSchema?: boolean
defaultOpen?: boolean
onOpenChange?: (open:boolean) => void
onOpenChange?: (open: boolean) => void
}

export default function Combobox({ isSelectGraph, disabled = false, inTable, type, options, setOptions, selectedValue = "", setSelectedValue, isSchema = false, defaultOpen = false, onOpenChange }: ComboboxProps) {

const [open, setOpen] = useState<boolean>(defaultOpen)
const [optionName, setOptionName] = useState<string>("")
const [editable, setEditable] = useState<string>("")
const [isUploadOpen, setIsUploadOpen] = useState<boolean>(false)
const [isDeleteOpen, setIsDeleteOpen] = useState<boolean>(false)
const [isUploadOpen, setIsUploadOpen] = useState<string>()
const [isDeleteOpen, setIsDeleteOpen] = useState<string>()
const onExport = async (graphName: string) => {
const result = await securedFetch(`api/graph/${prepareArg(graphName)}/export`, {
method: "GET"
Expand All @@ -57,6 +57,7 @@ export default function Combobox({ isSelectGraph, disabled = false, inTable, typ
}

const handelDelete = (option: string) => {

if (!setOptions) return
setOptions(prev => prev.filter(name => name !== option))
if (selectedValue !== option) return
Expand Down Expand Up @@ -92,7 +93,7 @@ export default function Combobox({ isSelectGraph, disabled = false, inTable, typ
<DropdownMenu open={open} onOpenChange={(o) => {
setOpen(o)
if (onOpenChange) onOpenChange(o)
}}>
}}>
<DropdownMenuTrigger asChild>
<Button
disabled={disabled}
Expand Down Expand Up @@ -192,24 +193,24 @@ export default function Combobox({ isSelectGraph, disabled = false, inTable, typ
disabled
variant="button"
icon={<UploadIcon />}
onClick={() => setIsUploadOpen(true)}
onClick={() => setIsUploadOpen(option)}
/>
</DropdownMenuItem>
<DropdownMenuItem className="p-2">
<Button
variant="button"
icon={<Trash2 />}
onClick={() => setIsDeleteOpen(true)}
onClick={() => setIsDeleteOpen(option)}
/>
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
<UploadGraph open={isUploadOpen} onOpenChange={setIsUploadOpen} />
<UploadGraph open={isUploadOpen === option} onOpenChange={(o) => setIsUploadOpen(o ? option : "")} />
<DeleteGraph
graphName={option}
isOpen={isDeleteOpen}
onOpen={setIsDeleteOpen}
onDeleteGraph={() => handelDelete(option)}
isOpen={isDeleteOpen === option}
onOpen={(o) => setIsDeleteOpen(o ? option : "")}
onDeleteGraph={handelDelete}
isSchema={isSchema}
/>
</TableCell>
Expand Down
5 changes: 5 additions & 0 deletions app/graph/GraphView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ const GraphView = forwardRef(({ graph, runQuery, historyQuery, setNodesCount, se
setQuery(historyQuery)
}, [historyQuery])

useEffect(() => {
setSelectedElement(undefined)
setSelectedElements([])
}, [graph.Id])

const handelSetSelectedElement = (element?: ElementDataDefinition) => {
setSelectedElement(element)
if (element) {
Expand Down
1 change: 1 addition & 0 deletions app/schema/SchemaView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export default function SchemaView({ schema, setNodesCount, setEdgesCount }: Pro

useEffect(() => {
setSelectedElement(undefined)
setSelectedElements([])
}, [schema.Id])

useEffect(() => {
Expand Down
Loading