Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Docker docs #25

Merged
merged 8 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bolt_support.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ nav_order: 10
description: "Connecting to FalkorDB using BOLT protocol."
---

## BOLT protocol support for FalkorDB
## [EXPERIMENTAL] BOLT protocol support for FalkorDB

FalkorDB provides support for querying using BOLT drivers.
FalkorDB provides an experimental support for querying using BOLT drivers.
gkorland marked this conversation as resolved.
Show resolved Hide resolved
This guide will walk you through the process of connecting to FalkorDB using the [BOLT protocol](https://en.wikipedia.org/wiki/Bolt_(network_protocol))

### Prerequisites
Expand All @@ -15,7 +15,7 @@ Before you begin, ensure that you have a FalkorDB instance up and running.
You can use our Docker image for this purpose.

```bash
docker run -p 6379:6379 -p7678:7678 -it -e REDIS_ARGS="--requirepass falkordb" -e FALKORDB_ARGS="BOLT_PORT 7678" --rm falkordb/falkordb:edge
docker run -p 6379:6379 -p 7678:7678 -p 3000:3000 -it -e REDIS_ARGS="--requirepass falkordb" -e FALKORDB_ARGS="BOLT_PORT 7678" --rm falkordb/falkordb:latest
gkorland marked this conversation as resolved.
Show resolved Hide resolved
```

Additionally, install the necessary BOLT drivers:
Expand Down
4 changes: 2 additions & 2 deletions configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Some of these parameters can only be set at load-time, while other parameters ca
For example the following will run the server with global authentication password and 4 threads.

```sh
docker run -p 6379:6379 -it -e REDIS_ARGS="--requirepass falkordb" -e FALKORDB_ARGS="THREAD_COUNT 4" --rm falkordb/falkordb:edge
docker run -p 6379:6379 -p 3000:3000 -it -e REDIS_ARGS="--requirepass falkordb" -e FALKORDB_ARGS="THREAD_COUNT 4" --rm falkordb/falkordb:latest
```

## Setting configuration parameters on module load
Expand Down Expand Up @@ -39,7 +39,7 @@ $ redis-server --loadmodule ./falkordb.so [OPT VAL]...
When running a docker container

```sh
docker run -p 6379:6379 -it -e FALKORDB_ARGS="[OPT VAL]" --rm falkordb/falkordb:edge
docker run -p 6379:6379 -p 3000:3000 -it -e FALKORDB_ARGS="[OPT VAL]" --rm falkordb/falkordb:latest
```

## Setting configuration parameters at run-time (for supported parameters)
Expand Down
2 changes: 1 addition & 1 deletion index.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ FalkorDB is a blazing fast graph database used for low latency & high throughput
Launch an instance using docker, or use our [sandbox](https://cloud.falkordb.com/sandbox)

```sh
docker run -p 6379:6379 -it --rm falkordb/falkordb:latest
docker run -p 6379:6379 -p 3000:3000 -it --rm falkordb/falkordb:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should specify the UI port (3000) in every example. I think it would be better to collect all of the docker configuration in one place, and have a single example of a docker run which exposes the UI port, all other examples should be kept to a minimum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should make it easy since you don't know how people will get to page directly from google.

```

Once loaded you can interact with FalkorDB using any of the supported [client libraries](/clients)
Expand Down
Loading