Skip to content

Enhance CI workflow with Node.js and build steps - #143

Merged
gkorland merged 1 commit into
mainfrom
gkorland-patch-2
Aug 27, 2025
Merged

Enhance CI workflow with Node.js and build steps#143
gkorland merged 1 commit into
mainfrom
gkorland-patch-2

Conversation

@gkorland

@gkorland gkorland commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Explicit startup command ensures consistent app launch in production.
  • Chores
    • Updated CI/CD to use a Makefile-driven, Node.js–assisted asset build.
    • Standardized runtime versions in pipeline (Python 3.12, Node.js 22).
    • Streamlined deployment artifacts by excluding unnecessary directories for leaner releases.

@coderabbitai

coderabbitai Bot commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The GitHub Actions workflow was revised to use Node.js and Makefile-driven asset building, switch dependency management to Pipenv, refine artifact packaging exclusions, add Python setup in deploy, and include an explicit uvicorn startup command for Azure Web App deployment.

Changes

Cohort / File(s) Summary
Build job updates
.github/workflows/main_queryweaver.yml
Replaced Python venv setup with Node.js 22 via actions/setup-node@v4; installed pipenv; ran make install and make build-prod; generated requirements.txt via pipenv requirements; expanded artifact exclusions (venv, node_modules, .git, test-results, playwright-report, tests/e2e/screenshots, pycache, Pipfile, Pipfile.lock).
Deploy job updates
.github/workflows/main_queryweaver.yml
Added actions/setup-python@v5 with python-version 3.12; retained Azure login; configured azure/webapps-deploy@v3 with startup-command: python -m uvicorn api.index:app --host 0.0.0.0 --port $PORT; minor permissions formatting and ensured trailing newline.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Dev as Commit/Push
    participant GH as GitHub Actions (Workflow)
    participant Build as Build Job
    participant Art as Artifact
    participant Deploy as Deploy Job
    participant Azure as Azure Web App

    Dev->>GH: Trigger workflow
    GH->>Build: Start build job
    Build->>Build: setup-node (Node.js 22)
    Build->>Build: Install pipenv
    Build->>Build: make install
    Build->>Build: make build-prod
    Build->>Build: pipenv requirements > requirements.txt
    Build->>Art: Upload packaged artifact (with expanded exclusions)

    GH->>Deploy: Start deploy job
    Deploy->>Deploy: setup-python (3.12)
    Deploy->>Azure: Azure login
    Deploy->>Art: Download artifact
    Deploy->>Azure: Deploy via azure/webapps-deploy@v3\nstartup-command: uvicorn api.index:app
    Azure-->>Dev: App runs on $PORT
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I thump my paws: build hops anew,
With Node and Make, we’re zipping through.
Pipenv whispers, deps aligned,
Uvicorn starts, the stars are timed.
To Azure clouds I gently leap—
Deploy complete; my carrots keep. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5e34372 and ac1d879.

📒 Files selected for processing (1)
  • .github/workflows/main_queryweaver.yml (2 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gkorland-patch-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel

vercel Bot commented Aug 27, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
queryweaver Building Building Preview Comment Aug 27, 2025 11:27am

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/setup-node 4.*.* 🟢 5.7
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 45 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 4
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 9binaries present in source code
Packaging⚠️ -1packaging workflow not detected
License🟢 10license file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Security-Policy🟢 9security policy file detected
Branch-Protection⚠️ 1branch protection is not maximal on development and all release branches
SAST🟢 9SAST tool is not run on all commits -- score normalized to 9
Vulnerabilities🟢 82 existing vulnerabilities detected

Scanned Files

  • .github/workflows/main_queryweaver.yml

@gkorland
gkorland merged commit 948ad35 into main Aug 27, 2025
8 of 11 checks passed
@gkorland
gkorland deleted the gkorland-patch-2 branch August 27, 2025 11:27
@coderabbitai coderabbitai Bot mentioned this pull request Aug 27, 2025
This was referenced Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant