Sri Lanka Provider Person and Phone Number #913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
pimjansen
requested changes
Feb 20, 2025
| * | ||
| * @method string phoneNumber() | ||
| * | ||
| * @property string $mobileNumber |
There was a problem hiding this comment.
Locale specific fields will not be included in the global generator
There was a problem hiding this comment.
Also for the others beneath this one
|
Added some comments, also please review the PR template and check all the checkboxes if something needs to happen. As it is right now it is not valid |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Enable Sri Lankan Locale data to faker data generation
Author's checklist
Summary of changes
This PR adds support for the en_SL locale, generating Sri Lankan local names, mobile Number, Nic number (Old and new Format)
Docs PR
Review checklist
CHANGELOG.md