Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

Commit

Permalink
Add PR reviewer requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
karelz authored Nov 30, 2018
1 parent 884b74f commit 16d5071
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Documentation/issue-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ Feel free to use other labels if it helps your triage efforts (e.g. **needs-more

### PR guidance

1. Dont't set any labels on PRs. They are superfluous and not needed (exceptions: **NO MERGE**).
Each PR has to have reviewer approval from at least one WPF team member who is not author of the change, before it can be merged.

1. Don't set any labels on PRs. They are superfluous and not needed (exceptions: **NO MERGE**).
* Motivation: All the important info (*issue type* label, API approval label, etc.) is already captured on the associated issue.
1. Push PRs forward, don't let them go stale (response every 5+ days, ideally no PRs older than 2 weeks).
1. Close stuck or long-term blocked PRs (e.g. due to missing API approval, etc.) and reopen them once they are unstuck.
Expand Down

0 comments on commit 16d5071

Please sign in to comment.