Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading ICU files on first run makes Ou Dedetai slow to open #234

Open
n8marti opened this issue Nov 23, 2024 · 2 comments · May be fixed by #206
Open

Downloading ICU files on first run makes Ou Dedetai slow to open #234

n8marti opened this issue Nov 23, 2024 · 2 comments · May be fixed by #206
Milestone

Comments

@n8marti
Copy link
Collaborator

n8marti commented Nov 23, 2024

The ICU files are checked for and downloaded before the GUI can appear, which makes the app seem to either not start or run very slowly. On a slow connection the user can be waiting for 30 seconds or more before seeing the app. Possible remedies:

  • Install ICU files in background thread
  • Don't check for ICU files when oudedetai runs, but rather when the installer or installed app are run
@thw26
Copy link
Collaborator

thw26 commented Nov 23, 2024

Could we put in a check as a third option of, run the check if the app is installed already, and then couple that without a background thread?

My only issue with this is we need to update the ICU files before run, preferably, so we would need to tell the manager not to launch Logos until ICU has finished updating.

@thw26 thw26 linked a pull request Nov 30, 2024 that will close this issue
@ctrlaltf24
Copy link
Contributor

Removed it from running when the app is first launched here: #206

However (as of now) new ICU files will never be pulled unless an operation is started explicitly saying so (like install ICU files on the GUI, install app on the cli, etc)

As noted 9f675c4#diff-23347a772a957e6fcda73364ccc1b1476e1868faa90873e4b2b9b8434118ea94R427-R435 when/how to run this may require further thought.

@ctrlaltf24 ctrlaltf24 linked a pull request Dec 3, 2024 that will close this issue
@thw26 thw26 added this to the Release 1.0.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants