Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The Menu Bug": Re-opening tools or layout menus fails the second time #193

Closed
ctrlaltf24 opened this issue Oct 6, 2024 · 5 comments
Closed
Assignees
Labels
bug Something isn't working logos not our bug Issue is in Wine, Logos itself, or something we can't account for on our side, such as an OS issue wine The issue is related to an upstream Wine issue.

Comments

@ctrlaltf24
Copy link
Contributor

ctrlaltf24 commented Oct 6, 2024

This may just be me (my window manager is weird)

Reproduction steps:

  • Open Logos 10 v38.1.6
  • Click on the Tools icon on the toolbar, then close it
  • Try to open the tools icon again, fails after trying to open for a second

It should be noted right clicking on a word in a bible works subsequent times

Let me know if there is more information/how I might further debug this issue

Workaround:

  • expand then un-expand the toolbar

Possible duplicates:

@thw26 thw26 added this to the Upstream Issues milestone Oct 6, 2024
@thw26 thw26 added bug Something isn't working not our bug Issue is in Wine, Logos itself, or something we can't account for on our side, such as an OS issue wine The issue is related to an upstream Wine issue. labels Oct 6, 2024
@thw26
Copy link
Collaborator

thw26 commented Oct 6, 2024

This bug is known as the menu bug in Telegram/Matrix/FL Forums.

Workarounds include expanding the toolbar and unexpanding it, then clicking again, or double clicking the menu item.

@jg00dman has been working on this one. It is an upstream wine issue.

@thw26
Copy link
Collaborator

thw26 commented Oct 8, 2024

We've had recent confirmation through testing and discussions with FaithLife that this issue is not a Wine regression, but rather Logos changed their code between versions 9.9 and 9.10, and this is what causes the menu bug. We will have to research how to fix this in Wine to account for Logos's code.

@thw26 thw26 changed the title Re-opening tools or layout menus fails the second time "The Menu Bug": Re-opening tools or layout menus fails the second time Oct 14, 2024
@ctrlaltf24
Copy link
Contributor Author

I wonder if they're using https://learn.microsoft.com/en-us/windows/win32/api/wtsapi32/nf-wtsapi32-wtsregistersessionnotification

This log was generated setting WINEDEBUG to +seh,+relay and only contains the time during the tools menu was opened for the first time, then a second time. I've saved a copy of this log for further diagnosis later.

cat ~/.local/state/FaithLife-Community/wine_just_menu_open_twice.log | grep "fixme"
0110:fixme:wtsapi:WTSRegisterSessionNotification Stub 0000000000030158 0x00000000
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE26D8B0) :semi-stub
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE269500) :semi-stub
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE267F40) :semi-stub
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE26B510) :semi-stub
0110:fixme:uiautomation:UiaReturnRawElementProvider Unsupported object id -4, ignoring.
0110:fixme:wtsapi:WTSUnRegisterSessionNotification Stub 0000000000030158
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE27A890) :semi-stub
0110:fixme:wtsapi:WTSRegisterSessionNotification Stub 0000000000040158 0x00000000
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE269DA0) :semi-stub
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE266300) :semi-stub
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE266E10) :semi-stub
0110:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007FFFFE266130) :semi-stub
0110:fixme:uiautomation:UiaReturnRawElementProvider Unsupported object id -4, ignoring.
0110:fixme:wtsapi:WTSUnRegisterSessionNotification Stub 0000000000040158
01e8:fixme:ntdll:RtlGetCurrentProcessorNumberEx (00007CBA646CF6E0) :semi-stub

@thw26
Copy link
Collaborator

thw26 commented Jan 11, 2025

A partial fix is forthcoming in 10rc5 via https://gitlab.winehq.org/wine/wine/-/commit/51b16963f6e0e8df43118deac63f640aee4698b7

This will need reported in Wine HQ.

@thw26 thw26 closed this as completed Jan 11, 2025
@ctrlaltf24
Copy link
Contributor Author

WineHQ bug updated https://bugs.winehq.org/show_bug.cgi?id=52380

Didn't file the follow-up (the second instance showing window decorations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logos not our bug Issue is in Wine, Logos itself, or something we can't account for on our side, such as an OS issue wine The issue is related to an upstream Wine issue.
Projects
None yet
Development

No branches or pull requests

3 participants