fix: honor -stderrthreshold by opting out of legacy klog behavior#454
Draft
pierluigilenoci wants to merge 1 commit intoFairwindsOps:masterfrom
Draft
fix: honor -stderrthreshold by opting out of legacy klog behavior#454pierluigilenoci wants to merge 1 commit intoFairwindsOps:masterfrom
pierluigilenoci wants to merge 1 commit intoFairwindsOps:masterfrom
Conversation
klog v2 defaults -logtostderr=true, which causes -stderrthreshold to be silently ignored (kubernetes/klog#212). klog v2.140.0 introduced the legacy_stderr_threshold_behavior flag to restore correct behavior (kubernetes/klog#432). Set legacy_stderr_threshold_behavior=false and stderrthreshold=INFO right after klog.InitFlags(nil) so that users can control log severity routing to stderr as intended. Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
klog v2 defaults
-logtostderr=true, which causes the-stderrthresholdflagto be silently ignored (kubernetes/klog#212).
This means users cannot control which severity levels are routed to stderr.
klog v2.140.0 introduced the
legacy_stderr_threshold_behaviorflag to fixthis (kubernetes/klog#432).
Nova already depends on klog v2.140.0, so the fix only requires opting in.
What changed
In
cmd/root.go, right afterklog.InitFlags(nil)and before the existingflag.Setcalls, two new flags are set:legacy_stderr_threshold_behavior=false— tells klog to respect-stderrthresholdeven when-logtostderr=true.stderrthreshold=INFO— routes INFO and above to stderr (matching thecurrent effective behavior, now explicitly declared).
Why
Without this change, passing
-stderrthreshold=WARNING(or any other value) toNova has no effect — all log levels still go to stderr because
-logtostderroverrides everything. After this change, users can filter stderr output by
severity as intended.
References