Skip to content

fix: honor -stderrthreshold when -logtostderr is set #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudermanjr merged 2 commits into from
Apr 23, 2026
+5 −0
Merged

fix: honor -stderrthreshold when -logtostderr is set #850

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41e414b
fix: honor -stderrthreshold when -logtostderr is set
pierluigilenoci Apr 23, 2026
7bf9d5e
Merge branch 'master' into fix/honor-stderrthreshold
sudermanjr Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ func init() {
rootCmd.PersistentFlags().StringVarP(&kubeconfig, "kubeconfig", "", "$HOME/.kube/config", "Kubeconfig location.")

klog.InitFlags(nil)
// Opt into the new klog behavior so that -stderrthreshold is honored even
// when -logtostderr=true (the default).
// Ref: kubernetes/klog#212, kubernetes/klog#432
flag.Set("legacy_stderr_threshold_behavior", "false") //nolint:errcheck
flag.Set("stderrthreshold", "INFO") //nolint:errcheck
pflag.CommandLine.AddGoFlag(flag.CommandLine.Lookup("v"))

environmentVariables := map[string]string{
Expand Down