Added option to use VpaMinReplicasAnnotation from labels #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option of using
goldilocks.fairwinds.com/vpa-min-replicas: X
as a label.Checklist
Description
Currently it is not possible to set vpa-min-relplicas with labels, like it is with some of the other options. This fix should ensure that is also the case for
vpa-min-replicas
What's the goal of this PR?
To support labels for
vpa-min-replicas
What changes did you make?
I added an if/else statement in the code where this was needed. The solution was inspired by how this is implemented other places in the code. Feel free to change it to your liking!
What alternative solution should we consider, if any?
blank