Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase verbose level for common operations #613

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Increase verbose level for common operations #613

merged 1 commit into from
Jun 27, 2023

Conversation

lauraseidler
Copy link
Contributor

@lauraseidler lauraseidler commented Jun 19, 2023

This PR fixes #564

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

Allow to significantly reduce the noise of the logs by setting the log level to 1, without turning off logs completely or affecting default functionality.

What changes did you make?

Increases the verbose level for common operation logs to 2 (which is the default log level).

What alternative solution should we consider, if any?

This addresses the issue described in #564, and increases the verbose
level for common operation logs to `2` (which is the default log level).
This allows to significantly reduce the noise of the logs by setting the
log level to `1`, without turning off logs completely or affecting default
functionality.
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks!

@sudermanjr sudermanjr self-assigned this Jun 27, 2023
@sudermanjr sudermanjr enabled auto-merge (squash) June 27, 2023 15:37
@sudermanjr sudermanjr merged commit ccda8aa into FairwindsOps:master Jun 27, 2023
@lauraseidler lauraseidler deleted the fix/reduce-log-verbosity branch June 28, 2023 10:57
@lauraseidler
Copy link
Contributor Author

@sudermanjr thank you! Unless it's already planned for the coming days anyway, could we get a new release for this? Would be much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goldilocks controller is too noisy even at v1
3 participants