Repository navigation
[hooks] decouple hook chain from clsx/tailwind #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /** | ||
| * Formats a date to a readable string format (e.g., "Jan 15, 2024, 3:45 PM"). | ||
| * | ||
| * Creates a new Intl.DateTimeFormat on each call intentionally — this runs | ||
| * server-side where there's no shared state concern. The client-side hot-path | ||
| * formatter in lib/log-format.ts caches its instance at module scope instead. | ||
| * | ||
| * Lives in its own module (rather than lib/utils.ts) so server-side callers | ||
| * — including the hook handler's transitive imports — don't need to pull in | ||
| * clsx/tailwind-merge just to format a date. | ||
| */ | ||
| export function formatDate(date: Date): string { | ||
| return new Intl.DateTimeFormat("en-US", { | ||
| month: "short", | ||
| day: "numeric", | ||
| year: "numeric", | ||
| hour: "numeric", | ||
| minute: "2-digit", | ||
| hour12: true, | ||
| }).format(date); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,15 @@ | ||
| /** | ||
| * General-purpose utility helpers. | ||
| * Tailwind class-name merger. | ||
| * | ||
| * - `cn()` — merges Tailwind CSS class names with conflict resolution. | ||
| * - `formatDate()` — human-readable absolute date/time string (no ms). | ||
| * `cn()` combines `clsx` (conditional class composition) with `tailwind-merge` | ||
| * (last-wins conflict resolution for Tailwind utility classes). | ||
| * | ||
| * Date formatting lives in lib/format-date.ts — kept separate so server-side | ||
| * callers don't need to load clsx/tailwind-merge just to print a timestamp. | ||
| */ | ||
| import { clsx, type ClassValue } from "clsx"; | ||
| import { twMerge } from "tailwind-merge"; | ||
|
|
||
| export function cn(...inputs: ClassValue[]) { | ||
| return twMerge(clsx(inputs)); | ||
| } | ||
|
|
||
| /** | ||
| * Formats a date to a readable string format (e.g., "Jan 15, 2024, 3:45 PM"). | ||
| * | ||
| * Creates a new Intl.DateTimeFormat on each call intentionally — this runs | ||
| * server-side where there's no shared state concern. The client-side hot-path | ||
| * formatter in lib/log-format.ts caches its instance at module scope instead. | ||
| */ | ||
| export function formatDate(date: Date): string { | ||
| return new Intl.DateTimeFormat("en-US", { | ||
| month: "short", | ||
| day: "numeric", | ||
| year: "numeric", | ||
| hour: "numeric", | ||
| minute: "2-digit", | ||
| hour12: true, | ||
| }).format(date); | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.