Handle protos without a package #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error reproduced minimal reproducer
jtjeferreira
commented
Feb 9, 2022
| @@ -104,7 +104,7 @@ public static void main(String[] args) { | |||
| String javaPackage | |||
| ) { | |||
| String filePath = javaPackage.replace(".", DIR_SEPARATOR) + DIR_SEPARATOR + fileName + JAVA_EXTENSION; | |||
| String fullMethodName = protoPackage + "." + messageDescriptor.getName(); | |||
| String fullMethodName = (protoPackage.isEmpty() ? "" : (protoPackage + ".")) + messageDescriptor.getName(); | |||
There was a problem hiding this comment.
not sure if this is the best way, but it works.
I saw a DOT_JOINER here, but it is not used with the protoPackage (i.e protoPackage + "." + e.getName() is what is used there)
|
Thanks for spotting this, though I'd really encourage defining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error when a proto has no package