Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make %context exec-dir inherited by further includes. #218 #219

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chen-factual
Copy link
Contributor

For #218. Ensures %includes in %context-ed scripts also inherit the context.

Example inclusion chain:

a.d context b.d include c.d contextd.d`.

The intended behavior is for b.d to use its own exec-dir, c.d to use the exec-dir of b.d, and d.d to use it's own exec-dir.

cc @potash if you can pull this branch and double check on your setup I'd be appreciative.

@potash
Copy link

potash commented Jul 6, 2016

Works for me! Thanks @chen-factual

@potash
Copy link

potash commented Jul 29, 2016

@chen-factual I think I spoke too soon. I think you somehow fixed the path that drake uses for subsequent %include and %context statements, but not the path used for step inputs and outputs. In fact it seems like %context is simple broken.

Here is a repo I made to test context. You should be able to run drake from either the top level or from the director dir but both fail for me on this branch.

Thanks in advance for your help with this! The %context feature will be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants