Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of fixing, rather than whinging, this is a quick fix for my issue #153. Splitting paths on
:
indrake.fs$split-path
returns('C', '\\data\\test.csv')
for properly formed windows paths. This causesdrake.fs$get-fs
to return[fs, 'C', '\\data\\test.csv]
. So, a basic function e.g.(fs di/data-in? "C:\\data\\test.csv")
goes to(di/data-in? fs '\\data\\test.csv')
which clearly breaks for windows.Splitting on "://" should still get the correct prefixes for e.g. s3://bucket.blah or hdfs://... without mangling the windows paths.
Note: It seems like there may be a different (and possibly cleaner?) solution to this using make-path more liberally, but it wasn't clear to me exactly where to use that, and this worked. Hence, the quick-fix appellation.