Implementation of checkpoints/temp targets #88 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2013 19:36
Squashed all the commits into one - in another branch
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| * bugfix: [#98](https://github.com/Factual/drake/issues/98) --help now doesn't run workflow (thanks marshallshen) | |||
| * Upgrade to c4 0.2.0, which no longer bundles the Facebook API | |||
| * New feature: temp targets (https://github.com/Factual/drake/issues/88) | |||
There was a problem hiding this comment.
i guess we should standardize on what we're calling this. is it "temp targets" or "checkpointing"?
There was a problem hiding this comment.
Good point - "temp targets" sounds good to me.
added 2 commits
November 14, 2013 12:53
#106 Standardize on name "temp targets" Use -> for cleaner code Add comments for ramifications of error when deleting temp target Also: made sure temp target testing is in the regtest suite
|
Checked in code review fixes - all tests pass. |
| [file] | ||
| (fs di/data-in? file)) | ||
|
|
||
| (defn- no-data-in? |
There was a problem hiding this comment.
(def no-data-in? (complement data-in?))
?
|
The code LGTM. But I think we should update the doc (pre-emptively) before releasing - I would love to see how this feature looks like from the end user's perspective. Ideally the documentation is easy to understand and covers edge cases as well. :) |
myronahn
pushed a commit
that referenced
this pull request
Jan 22, 2014
#106 Standardize on name "temp targets" Use -> for cleaner code Add comments for ramifications of error when deleting temp target Also: made sure temp target testing is in the regtest suite Conflicts: resources/regtest/run-all.sh src/drake/core.clj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed all the commits into one - in another branch
Ready for review.