Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Client Registry Remapping Only Remapping One Registry #4404

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Fix Client Registry Remapping Only Remapping One Registry #4404

merged 3 commits into from
Jan 29, 2025
+70 −4

Conversation

AViewFromTheTop
Copy link
Contributor

  • return was used instead of continue, causing only the last modified registry to sync to the client.
    Fix is simply using an if-else statement instead of calling return within the if statement.

@AViewFromTheTop
WW DEBUG
2e1d4a8 
Revert "apple log"

This reverts commit e3ba09c.

Possible Fix

apple log

Update RemapStateImpl.java

Revert "WW DEBUG"

This reverts commit 3f2ffa9.
@AViewFromTheTop
Fix Client Registry Remapping Only Remapping One Registry
68e42ba
@apple502j apple502j added bug Something isn't working registry-sync Pull requests and issues related to registry sync small change priority:high High priority PRs that need review and work now. Review these first. labels Jan 29, 2025
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Jan 29, 2025
modmuss50
modmuss50 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a unit test, many thanks for getting to the bottom of this.

@modmuss50 modmuss50 merged commit 4ba56ac into FabricMC:1.21.4 Jan 29, 2025
4 checks passed
modmuss50 pushed a commit that referenced this pull request Jan 29, 2025
@AViewFromTheTop @modmuss50
Fix Client Registry Remapping Only Remapping One Registry (#4404)
4aeee1c 
* WW DEBUG

Revert "apple log"

This reverts commit e3ba09c.

Possible Fix

apple log

Update RemapStateImpl.java

Revert "WW DEBUG"

This reverts commit 3f2ffa9.

* Fix Client Registry Remapping Only Remapping One Registry

* Add unit test

---------

Co-authored-by: modmuss50 <[email protected]>
(cherry picked from commit 4ba56ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge me please Pull requests that are ready to merge priority:high High priority PRs that need review and work now. Review these first. registry-sync Pull requests and issues related to registry sync small change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AViewFromTheTop @modmuss50 @apple502j