Add waitTick built-in to pressKey and pressMouse #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Jan 8, 2025
modmuss50
added
merge me please
modmuss50
pushed a commit
that referenced
this pull request
Jan 14, 2025
(cherry picked from commit 5f21acd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the footgun that the effects of key bindings aren't felt until a tick is waited.
This is a symptom of a wider issue with having the game suspended while gametest code is running, that sometimes the game needs to tick to see the effects of your code, depending on how that specific component of the game was coded. I don't think there is a way to completely solve this issue without reverting to running concurrently with the game which introduces thread safety issues which I believe are more dangerous.
I've added some documentation specifically warning users about the issue of delayed effects, and encouraging them to take debug screenshots to figure out what's going on, and that a simple
waitTickcould be the solution to their issue.