Fix MutableQuadViewImpl#fromVanilla methods not setting correct normal flags
#4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l flags - The (int[], int) overload used to keep the normal flags as is - The (BakedQuad, RenderMaterial, Direction) overload used to reset all normal flags - The normal flag for a vertex is now set if and only if the normal is not zero, ignoring the W component - Clarify that MutableQuadView#fromVanilla(BakedQuad, ...) resets the quad tag
PepperCode1
added
bug
Technici4n
approved these changes
Jan 5, 2025
modmuss50
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(int[], int)overload used to keep the normal flags as is(BakedQuad, RenderMaterial, Direction)overload used to reset all normal flagsMutableQuadView#fromVanilla(BakedQuad, ...)resets the quad tag