-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve inconsistency issues in client gametests #4334
Merged
modmuss50
merged 13 commits into
FabricMC:1.21.4
from
Earthcomputer:client-gametest-locking-once-per-tick
Jan 7, 2025
Merged
Solve inconsistency issues in client gametests #4334
modmuss50
merged 13 commits into
FabricMC:1.21.4
from
Earthcomputer:client-gametest-locking-once-per-tick
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earthcomputer
changed the title
Make sure client locking only happens if there will actually be a tick
Solve inconsistency issues in client gametests
Dec 29, 2024
Earthcomputer
force-pushed
the
client-gametest-locking-once-per-tick
branch
from
January 5, 2025 17:59
69c045f
to
707004e
Compare
…he vanilla queue, not after
…entally change this value without using the setter.
modmuss50
added
enhancement
New feature or request
test
priority:high
High priority PRs that need review and work now. Review these first.
labels
Jan 7, 2025
modmuss50
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not going to pretend to understand all the logic, but as with the previous PRs the reasoning is sound. Thanks for all the effort with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
merge me please
Pull requests that are ready to merge
priority:high
High priority PRs that need review and work now. Review these first.
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the two biggest remaining consistency issues with client gametests that I have encountered:
waitTick
is run.NetworkSynchronizer
to solve this issue.NetworkSynchronizer
is careful not to assume that all packets must be added to the task queue.