Biomemodifications: Check to make sure Feature isn't present before adding it #4323
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe a log? |
|
Like print it to the console log that this is happening? |
|
Thinking maybe a debug or a warn or? In my head putting it in like info doesn't make sense as this could happen very easily with tags and it's not like a "bad" thing it's just something that happens |
|
I think this seems fine, as it can happen in a valid case. We would only tend to log if something was broken. |
modmuss50
added
bug
modmuss50
approved these changes
Dec 29, 2024
modmuss50
pushed a commit
that referenced
this pull request
Dec 30, 2024
(cherry picked from commit b1c29d8)
modmuss50
pushed a commit
that referenced
this pull request
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a feature order cycle error will happen because a feature may be added to a biome twice. This can occur if a biome appears in more than one tag and you want a feature in biomes from both tags, currently it gets added twice to the biome causing a feature order cycle error