Fix custom ingredient implementation #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Override isEmpty in CustomIngredientImpl - Override acceptsItem in CustomIngredientImpl - Override equals and hashCode in CustomIngredientImpl so CustomIngredients can also implement them - Adjust the class doc of CustomIngredient to encourage implementors to do so - Implement Ingredient#hashCode - Remove incorrect Nullable annotation from ItemStack parameter in CustomIngredientImpl#test - Implement equals and hashCode on all builtin custom ingredient classes
PepperCode1
added
bug
Technici4n
approved these changes
Dec 5, 2024
modmuss50
approved these changes
Dec 5, 2024
apple502j
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEmptyinCustomIngredientImplacceptsIteminCustomIngredientImplequalsandhashCodeinCustomIngredientImplsoCustomIngredients can also implement themCustomIngredientto encourage implementors to do soIngredient#hashCodeNullableannotation fromItemStackparameter inCustomIngredientImpl#testCustomIngredient#toDisplayas createdRegistryEntryListwould always contain right storageequalsandhashCodeon all builtin custom ingredient classesFixes #4270.