Allow IDEA run configs to be generated for non-root projects #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse uses "-" as path separator between parent and child projects whereas IDEA uses ".". Gradle: ":1.16.1" (with rootProject named "root") Eclipse: "root-1.16.1" IDEA: "root.1.16.1.main"
So instead of having three "Minecraft Client" run configs, you now get "Minecraft Client (:1.16.1)", "Minecraft Client (:1.15.2)", etc.
Johni0702
force-pushed
the
subproject-run-configs
branch
from
c001456 to
3f161d9
Compare
|
The build failure seems random and unrelated to the changes afaict. |
modmuss50
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Default behavior should be almost unchanged, only difference being that
autoGenIDERunsnow defaults tofalsefor subprojects (for backwards compat) and only when it's set totrue, will run configs be generated (as opposed to before where they were never generated).