Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Documentation - Example usage #49

Open
GregorBecker opened this issue Feb 15, 2024 · 1 comment
Open

[JOSS] Documentation - Example usage #49

GregorBecker opened this issue Feb 15, 2024 · 1 comment

Comments

@GregorBecker
Copy link

Hi, I have a question about the examples/tutorial section in JOSS Review 6274.

I've found the "Tutorial" section in your documentation where you only tell the modeling tool user that the examples are located in the "examples" folder.

In my opinion, it would be useful to present a brief description of each example (as found in the example notebooks) and link to them individually. This should include an introductory text and a logical order in which to use the examples to help the user learn how to use your software product.

I would also like to point out two formal things. First, you specify units in square brackets. Although this is common practice, it is not formally correct. Furthermore, it is not allowed to append indices to SI units. It would be nice if you could adapt this in your examples.

Nevertheless, I would like to emphasize that the description of the examples in the documentation is of greater importance.

Kind regards
@GregorBecker

k-knosala added a commit that referenced this issue Mar 21, 2024
[JOSS Issue #49] Documentation - Example Usage

See merge request iek-3/shared-code/fine!335
@t-gross
Copy link
Collaborator

t-gross commented Mar 22, 2024

Thank you for question and comments. In develop branch, we added short descriptions and the links to the individual examples. The examples were ordered.
The descriptions and links to the examples were added in ReadTheDocs (Tutorial) and in the README file (both currently only available in develop branch).
We will also work on the unit issue (thanks for raising it!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants