Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #774 #775

Merged
merged 4 commits into from
Nov 4, 2018
Merged

Fixes #774 #775

merged 4 commits into from
Nov 4, 2018

Conversation

MrChebik
Copy link
Contributor

No description provided.

@Jugen
Copy link
Collaborator

Jugen commented Sep 7, 2018

@MrChebik Thanks for the patch and pull request, however your changes causes the following two tests to fail:

  1. PositionTests.end_position_is_correct_when_change_occurs_at_position @ line 137
  2. PositionTests.end_position_is_correct_when_change_occurs_after_position @ line 153

Please review your fix so that all tests pass :-)
Thank you.

@goxr3plus
Copy link
Collaborator

@Jugen Tests are now passing .

@rustem-s
Copy link

Dear @Jugen!
When you approve this pull request?
This bug also bothers us.

@MrChebik
Copy link
Contributor Author

MrChebik commented Oct 25, 2018

Hi, @rustem-s, you can use forked project with bug fix.

<repositories>
    <repository>
        <id>jitpack.io</id>
        <url>https://jitpack.io</url>
    </repository>
</repositories>

// ...

<dependency>
    <groupId>com.github.MrChebik</groupId>
    <artifactId>RichTextFX</artifactId>
    <version>cabee30961</version>
</dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants