-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup integration test #601
Cleanup integration test #601
Conversation
I'm out of time for today, but I am going to see if the Mac build will pass if I run the HitTests tests that currently fail on Mac now that we have a more accurate way of determining the caret's paragraph |
@JFormDesigner Per your comments here, I've rewritten some tests to use the |
@afester I appreciate that you submitted the PR, but I decided to revert what you did in #589 (the glass adapter) in this PR. We may need to revert my change, so that it's back to yours (at least when Gradle detects that Windows is running it). I hope to know more once I get the Windows CI set up properly. |
To summarize:
NavigationTests
into their own separate files for easier managementRichTextFXTestBase
) in case one needs to use a different area flavor (e.g.GenericStyledArea
) while still having access to OS-related things and position helper methodsContextMenuTests
, clear clipboard before tests run)StringBuilder
to only do so oncegetCharacterBoundsOnScreen
(see commit messages for full list of changes)