Skip to content

Handle drag events only if mouse release occurred inside of view #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2016
Merged

Handle drag events only if mouse release occurred inside of view #371

merged 1 commit into from
Oct 4, 2016

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Oct 4, 2016 •
edited
Loading

This should fix #321

@TomasMikula
Copy link
Member

Shouldn't the test be inside of the DRAG case?

@JordanMartinez
Copy link
Contributor Author

Shouldn't the test be inside of the DRAG case?

The caret will still move then, but that's what happens in a TextArea, too, (just tested it). So, yeah, it should.

@JordanMartinez
Copy link
Contributor Author

I've updated the PR

@JordanMartinez JordanMartinez mentioned this pull request Oct 4, 2016
Closed
@TomasMikula
Copy link
Member

👍

@TomasMikula TomasMikula merged commit 708ea4c into FXMisc:master Oct 4, 2016
@JordanMartinez JordanMartinez deleted the abortDragOnOutsideViewMouseRelease branch October 4, 2016 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected text drag behavior on abort.
2 participants
@JordanMartinez @TomasMikula