Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple esd #309

Merged
merged 3 commits into from
May 14, 2016
Merged

Simple esd #309

merged 3 commits into from
May 14, 2016

Conversation

JordanMartinez
Copy link
Contributor

No description provided.

@JordanMartinez
Rename implementation of EditableStyledDocument to SimpleEditableStyl…
5b88b86 
…edDocument
@JordanMartinez
Make SimpleEditableStyledDocument public
9797baa 
- SESD's other constructor was intentionally not made public. Initialization will always be a blank document that can be further modified through its API, not its constructor.
@TomasMikula
Copy link
Member

Thanks! We probably shouldn't add any more public methods than those declared in EditableStyledDocument. That means we should remove the replaceText method, which would require to rewrite the tests that use it.

@JordanMartinez
Copy link
Contributor Author

How about now?

@TomasMikula
Copy link
Member

👍

@TomasMikula TomasMikula merged commit 71f8bca into FXMisc:master May 14, 2016
@JordanMartinez JordanMartinez deleted the simpleESD branch May 15, 2016 02:01
@JordanMartinez JordanMartinez mentioned this pull request Jun 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @TomasMikula