Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mommy has zsh completion integration~ #48

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

natawie
Copy link
Contributor

@natawie natawie commented Mar 4, 2023

#43

also if that's alright i can add to build.sh so that it copies the definition file to e.g. /usr/local/share/zsh/site-functions or /usr/share/zsh/site-functions which are the defaults

@FWDekker
Copy link
Owner

FWDekker commented Mar 4, 2023

wow, awesome! thanks for the contribution :-)

as for updating build.sh, i'm currently looking into changing the build process to be a little bit less... messy, probably using a Makefile or something, which should make it much easier to extend for adding more files, and should remove a lot of redundancy. so once i've done that i'll add these completions to the build.sh ^^

also, don't worry about the failing build, that one's new and apparently it cannot handle checking out to forks yet, oops

@FWDekker FWDekker merged commit ac22afd into FWDekker:dev Mar 4, 2023
@FWDekker FWDekker self-assigned this Mar 4, 2023
@FWDekker FWDekker added the feature New feature or request label Mar 4, 2023
@FWDekker
Copy link
Owner

FWDekker commented Mar 5, 2023

the new build system is now in place in the dev branch! just a few more things i want to do before i'll merge this all into main and release it as mommy v1.3.0:

  • fix a small big with fish's autocompletions
  • add tests that verify that autocompletions have been installed correctly (because right now i'm not sure it's in the right directory? apparently some systems (e.g. debian) want /usr/local/share/zsh/site-functions/ and others (e.g. brew) want /usr/share/zsh/site-functions/
  • add completions for bash

either way, i've also added you to the acknowledgements of the readme. it's in dev for now, but will be merged into main together with the rest :)

@FWDekker
Copy link
Owner

FWDekker commented Mar 9, 2023

v1.2.2 has been released, with the abovementioned remaining tasks completed, except there are no bash completions yet. maybe in a future version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants