CI: Use OCaml 5.3.0 #650
Merged
CI: Use OCaml 5.3.0 #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently a problem with OCaml's pprintast/ppxlib in that it generates "raw identifiers" like `\#module` which are not valid in OCaml below 5.2.0 See ocaml/opam-repository#28610 (comment) for some discussion. I think this will be fixed upstream, but bumping to OCaml 5.3.0 seems useful anyway. (We can also work around it by using `" module"` instead of `"module"` in lib/GenCtypes.ml, but that's nasty.)
Collaborator
|
Fine by me. @Nadrieril I think we're also using 5.3.0 for the nix builds, aren't we? |
|
We're using 5.2 it seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a problem with OCaml's pprintast/ppxlib in that it generates "raw identifiers" like
\#modulewhich are not valid in OCaml below 5.2.0See ocaml/opam-repository#28610 (comment) for some discussion.
I think this will be fixed upstream, but bumping to OCaml 5.3.0 seems useful anyway. (We can also work around it by using
" module"instead of"module"in lib/GenCtypes.ml, but that's nasty.)PS. I looked at adding a Nix CI, but adding
checkPhase = "make test"didn't work for me. I also have no idea how to change the dependencies such as this OCaml version, so I would leave changing the CI to someone else.