Send response when lookup IDE request fails. #3189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So apparently the |
I've added a new internal query type to ignore errors. The |
|
The vscode extension now avoids the awkward version of the lookup query, and no longer uses the internal lookup queries either. The right choice is probably to just remove the internal lookup queries entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lookuprequest is the only one which does not return any response if the request failed. This makes it hard to support it in a generic API for IDE requests. See discussion at FStarLang/fstar-vscode-assistant#27 (comment)The history of the failure response for this request is interesting: it has flipped several times over the last year. I have summarized the responses for the different editors in the table below. I could not find any justification for the changes, the current vscode extension seems to work just fine with the change. This PR effectively reverts the behavior to how it was in 2022.