-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing some dependencies from the compiler into ulib #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need FStar.Char for literals.
This looks great, Guido ... thanks! I've kicked an everest build as well (on everest branch nik_wf) just to check that we don't have anyone relying on BaseTypes in HACL etc. If it all comes back green, please merge |
oops, good point! I now see everparse uses it. Feel free to kill that build as I make a PR for it. |
Got a local green, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the commit message:
This PR also adds a rule to easily obtain a PDF of the dependency graph of the compiler. Here's before and after (maybe not a "considerable" reduction come to think of it :) )
depgraph_old.pdf
depgraph_new.pdf
This also saves about a minute of (sequential) bootstrapping time.