Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash LSP server on malformed Content-Length #2526

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Do not crash LSP server on malformed Content-Length #2526

merged 3 commits into from
Apr 11, 2022

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented Apr 3, 2022

Closes #2524

@kant2002 kant2002 mentioned this pull request Apr 11, 2022
Merged
@aseemr
Copy link
Collaborator

aseemr commented Apr 11, 2022

Thanks @kant2002, the PR looks good to me content-wise. A couple of structural comments:

  • tests/cleanup.py seems a little out-of-place, how about a directory structure tests/ide and then two subdirectories for emacs and lsp, then cleanup.py can live in tests/ide?
  • There seems to be a lot of duplication in lsp/Makefile from the current interactive/Makefile, can we put common parts in a tests/ide/Makefile.common, and then the two emacs/Makefile and lsp/Makefile include it?

@kant2002
Copy link
Contributor Author

@aseemr I'm not a Make expert so maybe I do something bad from practical perspective. But all folders works for me.

@aseemr aseemr merged commit 6e4b218 into FStarLang:master Apr 11, 2022
@aseemr
Copy link
Collaborator

aseemr commented Apr 11, 2022

Thanks!

@kant2002 kant2002 deleted the kant/lsp-fix branch April 11, 2022 11:09
@nikswamy
Copy link
Collaborator

Thank you Andrii for this PR and thanks Aseem for handling it! It's great to see progress on the LSP front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP crashed when given malformed Content-Header
3 participants
@kant2002 @aseemr @nikswamy