Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Implement Link-Local Next Hop capability #17871

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Jan 17, 2025

Implementing https://datatracker.ietf.org/doc/html/draft-white-linklocal-capability.

=> frrbot skipped intentional according to our conventions.

@frrbot frrbot bot added bgp documentation tests Topotests, make check, etc labels Jan 17, 2025
@ton31337 ton31337 force-pushed the feature/bgp_link_local_capability branch from 0d5556e to d69fa2f Compare January 17, 2025 11:52
@donaldsharp
Copy link
Member

I've read the proposed draft and I'm not sure I am happy with the error handling aspect of it and how it works with older versions ( it's not specific enough imo )
I've started a conversation with Jeff/Russ and Donatas in slack to get to the bottom.

@ton31337 ton31337 force-pushed the feature/bgp_link_local_capability branch from d69fa2f to ffc0a8e Compare January 17, 2025 14:36
Related: https://datatracker.ietf.org/doc/html/draft-white-linklocal-capability

TL;DR; use 16 bytes long next-hops for point-to-point (unnumbered) links instead
of sending 32 bytes (::/LL, GUA/LL, LL/LL combinations).

For backward compatiblity we should handle even 32 bytes existing next hops.

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the feature/bgp_link_local_capability branch from ffc0a8e to db853cc Compare January 17, 2025 14:49
@donaldsharp
Copy link
Member

interface based peering is already supposed to do this. Why not just use that for this feature? As I understand it if we peer with a older version of FRR then it would still work. In other words why do we need a new knob when we have one already?

@ton31337
Copy link
Member Author

interface based peering is already supposed to do this. Why not just use that for this feature? As I understand it if we peer with a older version of FRR then it would still work. In other words why do we need a new knob when we have one already?

you mean "neighbor X interface ..."?

@donaldsharp
Copy link
Member

yes exactly. neighbor swp1 interface ....

@ton31337
Copy link
Member Author

ton31337 commented Jan 17, 2025

That would be probably fine. But I'm thinking what if I want to drop this capability (for some backward compatible SNAFU), but keep the session UP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants