Fix Rocky 8 RPMs, add options to build without rpki and docs (default is to include) #17793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for different system environments by including all built .so files
Simplify file list by using wildcards to include any built %{_libdir}/frr/modules/*.so and +%{_libdir}/libfrr*.so*
Signed-off-by: Lou Berger <[email protected]>
…(Centos 8 is no more) Signed-off-by: Lou Berger <[email protected]>
louberger
force-pushed
the
working/lb/fix-r8-rpms
branch
from
a96a05f to
e2b5eed
Compare
mjstapp
approved these changes
Jan 8, 2025
|
A question about the developer docs: should we (could we) have a "building for rocky"? would a copy of the centos8 doc still be correct/useful? |
|
I would think the centos8 doc should be sufficient. |
|
CI:rerun |
|
CI:rerun Need to retest against new master base |
|
The static analyzer error is in the base, not in this PR. The CI does a compare against the wrong base (Base of PR) instead of the latest master (the CI run does the PR rebased on the latest master, so that should be the base). |
mwinter-osr
approved these changes
Jan 21, 2025
Jafaral
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix generation of rpms for RHEL/Rocky8. default behavior is not changed by addition of new rpmbuild (command line) options.