Advertise routes matching bgp path #17777
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'show bgp <afi> <safi> neighbors <peer> advertised-routes detail' command displays all the bgp paths of the loc-rib. The expectation is that it displays only the bgp path for the peer this path is sent to. Fix this by replacing the extra attr attribute with the bgp_adj_out pointer of the path to display. Filter out the appropriate bgp path and display the adj->attr. Fixes: e960b4c ("bgpd: add "detail" for advertised/received-routes") Signed-off-by: Philippe Guibert <[email protected]>
Add a test that check that the detailed command of show bgp advertised neighbors 10.125.0.2 displays the locpref value. Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
advertise_routes_matching_bgp_path
branch
from
572bb5f to
b7fd45c
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bgpd: fix display the attr from adj-rib-out with detail used
The 'show bgp neighbors advertised-routes detail'
command displays all the bgp paths of the loc-rib. The expectation is
that it displays only the bgp path for the peer this path is sent to.
Fix this by replacing the extra attr attribute with the bgp_adj_out
pointer of the path to display. Filter out the appropriate bgp path and
display the adj->attr.